Ticket #804 (closed defect: fixed)
encoding combobox in blame and diff doesn't work
| Reported by: | koop@… | Owned by: | alwin |
|---|---|---|---|
| Priority: | normal | Milestone: | not applicable |
| Component: | All | Version: | 0.8.x |
| Severity: | tweak | Keywords: | |
| Cc: |
Description
Changing the item in the encoding combobox doesn't work, because the signal from the combobox is not connected to the slot. The patch fixes this:
diff -cr org/kdesvn-1.5.3/src/ksvnwidgets/encodingselector_impl.cpp new/kdesvn-1.5.3/src/ksvnwidgets/encodingselector_impl.cpp * org/kdesvn-1.5.3/src/ksvnwidgets/encodingselector_impl.cpp 2009-08-16 23:14:31.000000000 +0200 --- new/kdesvn-1.5.3/src/ksvnwidgets/encodingselector_impl.cpp 2010-07-22 10:46:43.955556680 +0200 * * 28,33 --- 28,36 ----
: QWidget(parent)
{
setupUi(this);
+ connect(m_encodingList,SIGNAL(itemActivated(int)), + this, SLOT(itemActivated(int))); +
m_encodingList->addItems( KGlobal::charsets()->availableEncodingNames());
}
* * 35,40 --- 38,47 ----
: QWidget(parent)
{
setupUi(this);
+ connect(m_encodingList,SIGNAL(activated(int)), + this, SLOT(itemActivated(int))); +
if (name) {
setObjectName(name);
}
blame me... :(