Compile error under AMD 64 bit

[bpe2004@…]

Compile error under AMD 64 bit Using gcc 4.2.1 , subversion 1.4.4, kde 3.5.7, qt 3.3.8

Linking CXX shared module ../lib/kde3/libkdesvnpart.so /usr/bin/ld: /src/kdesvn-0.13.0/lib/kde3/libsvnfrontend.a(svnitem.o): relocation R_X86_64_PC32 against `vtable for svn::ref_count' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: ld returned 1 exit status make[2]: * [lib/kde3/libkdesvnpart.so] Error 1 make[1]: * [src/CMakeFiles/kdesvnpart.dir/all] Error 2 make: * [all] Error 2

[bpe2004@…]

Using latestfrom svn (0.14 ?) produces same error.

[alwin]

Some more details about machine and distribution/system would be helpfull. What version of cmake? 'cause on all systems known to me it works.

[bpe2004@…]

distro -> "Linux from scratch, CBLFS x86-64_64 on an Intel Pentium D, non-multi-lib thus I don't have 32bit libs nor 32 bit compiler, " http://cblfs.cross-lfs.org/index.php/Main_Page"

gcc 4.2.1

binutils 2.17

qt 3.3.8

kde 3.5.7

cmake version 2.4-patch 6

also tried 2.4-patch 7

I'm not familar with cmake nor QT or KDE, actually the error happen in a different object from 0.13 (svnitem.o) vs. trunk (svnlogdlgimp.o). I tried the QValueList sample from QT which does work and apparently svnqt.so does link Ok were the QValueList template with QString is used too.

I did build as below from 'trunk' directory

mkdir build; cd build; cmake ../. make

Failure:

Linking CXX shared module ../lib/kde3/libkdesvnpart.so

/usr/bin/ld: /home/w11281/src/kdesvn_svn/trunk/build/lib/kde3/libsvnfrontend.a(svnlogdlgimp.o): relocation R_X86_64_PC32 against QValueList<QString>::detachInternal() can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: ld returned 1 exit status make[2]: * [lib/kde3/libkdesvnpart.so] Error 1 make[1]: * [src/CMakeFiles/kdesvnpart.dir/all] Error 2

Same failure happen if I do gcc -shared 'ls *.o' ' in build/src/svnfrontend/CMakeFiles/svnfrontend.dir. If I then remove svnlogdlgimp.o above gcc -shared 'ls *.o ' will link w/o error. Seems the problem is somehow with QValueList in svnlogdlgimp.o

After commenting line ~112 in svnlogdlgimp.cpp I get a link failure as above but for QMap ( relocation R_X86_64_PC32 against QMap<long, svn::LogEntry?>:: operator[](long const&)'

LogListViewItem::LogListViewItem(KListView*_parent,const svn::LogEntry&_entry)
    : KListViewItem(_parent),_realName(QString::null)
{
............
    QStringList sp = QStringList::split("
",_message);
    if (sp.count()==0) {
          setText(COL_MSG,_message);
    } else {
 //       setText(COL_MSG,sp[0]); // caused link error
    }
    changedPaths = _entry.changedPaths;
..................

I re-installed QT from source ( 3.3.8 ) acc. to CBLFS instruction, but symptom remains same. I did compile several other packages incl. KDE, I only saw this link failure with kdesvn so far.

[alwin]

Replying to bpe2004@fastmail.fm:

Ah, ok.

Seems that there is an error inside that cmake doesn't set this flag itself (what it should do) or some defaults are different. I'll check it today.

You must not fiddle with source code, the problem is that - why ever - cmake doesn't set the "-fPIC" flag. (On other system it does, thats why my question).

For a fast workaround you may add "ADD_DEFINITION(-fPIC)" after line

"ENDIF (HAVE_GCC_VISIBILITY)"

in main CMakeLists.txt.

I'll try to integrate a better solution (eg. setting this flag only where real needed, but it doesn't make problems when set on 64bit platforms)

Tnx for your effort

[anonymous]

Thanks for your fast reply,

I did try "ADD_DEFINITION(-fPIC)" seems not known by cmake so I did "ADD_DEFINITIONS(-fPIC)" which acc. to cmake man page does add -D defines. This didn't help, so I added

SET (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")

instead. However this didn't help either. Not sure if I looked into the right file, but in

svnfrontend/CMakeFiles/svnfrontend.dir
the file flags.make does contain -fPIC, it can also be seen in build.make after /usr/bin/c++ commands. cmake seem to first explicit run the pre-processor,assembly than somehow to object. ( -E, than -S flag). I could not figure out the flags for the last compile step.

I thought that if -fPIC is missing I should get a lot more errors on other modules too.

Let me know if there is anything you want me try, Thanks,

[bpe]

I noticed that the failure happen on QT template members that potentially should be "inline" ( detachInternal in qvaluelist.h ).
I added below line to the top CMakeLists.txt at the location you previously suggested and the code can compile and does work :)

......
ADD_DEFINITIONS("-DQ_INLINE_TEMPLATES=inline")
......

My QT installion doesn't define "Q_INLINE_TEMPLATES" to inline, not sure whether it should, in the QT include qglobal.h it seems not defined to "inline" for GNU compilers.

So this doesn't seem to be a kdesvn defect after all, more likely a problem with my installation or QT 3.3.8.